[Webkit-unassigned] [Bug 50949] Add support for unicode-bidi:plaintext CSS property
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 23 15:00:10 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=50949
--- Comment #23 from Levi Weintraub <leviw at chromium.org> 2011-06-23 15:00:09 PST ---
(From update of attachment 98211)
View in context: https://bugs.webkit.org/attachment.cgi?id=98211&action=review
>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:967
>> + bool isNewUBAParagraph = lineInfo.previousLineBrokeCleanly();
>
> I wonder if this shouldn't be an accessor on lineInfo. So that at some point later we might distinguish between nextLineIsNewUBAParagraph and previousLineBrokeCleanly (since I think they're used for separate things a times).
I'd agree this should be refactored when another use case crops up.
>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:991
>> + }
>
> Why is this needed here? I would think you would only need this in determinedStart... below.
On all other modes, hitting a hard line break resets the UBA to the state at the beginning of the current block, but when in Unicode: plaintext mode, we recalculate the direction of this new paragraph and set the status to an embedding level of 0/1 depending on the first character with strong directionality.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list