[Webkit-unassigned] [Bug 63281] TestFailures page fetches build JSON for every build, which is slow and limits history to the last build master restart

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 23 14:38:22 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63281





--- Comment #4 from Adam Roben (:aroben) <aroben at apple.com>  2011-06-23 14:38:22 PST ---
(From update of attachment 98404)
View in context: https://bugs.webkit.org/attachment.cgi?id=98404&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:247
>> +        var resultsHTMLIncludesTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildIncludesTooManyFailuresInfo(buildName);
> 
> I don't like "Includes" in this variable name because that implies (just reading the variable name) that this particular build has info about too many failures.  How about using "Supports" instead of "Includes"?
> 
> var resultsHTMLSupportsTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildSupportsTooManyFailuresInfo(buildName);

Good suggestion. I'll go with that!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list