[Webkit-unassigned] [Bug 50949] Add support for unicode-bidi:plaintext CSS property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50949


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98211|review?                     |review-
               Flag|                            |




--- Comment #22 from Eric Seidel <eric at webkit.org>  2011-06-23 14:35:21 PST ---
(From update of attachment 98211)
View in context: https://bugs.webkit.org/attachment.cgi?id=98211&action=review

r- for the cr-linux failure.  Happy to look again after your replies.

> Source/WebCore/html/HTMLElement.cpp:129
> +static inline int unicodeBidiAttributeForDirAuto(HTMLElement* element)

So sad that these are ints, and not an enum.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:967
> +        bool isNewUBAParagraph = lineInfo.previousLineBrokeCleanly();

I wonder if this shouldn't be an accessor on lineInfo.  So that at some point later we might distinguish between nextLineIsNewUBAParagraph and previousLineBrokeCleanly (since I think they're used for separate things a times).

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:991
> +            if (isNewUBAParagraph && style()->unicodeBidi() == Plaintext && !resolver.context()->parent()) {
> +                TextDirection direction = style()->direction();
> +                determineParagraphDirection(direction, resolver.position());
> +                resolver.setStatus(BidiStatus(direction, style()->unicodeBidi() == Override));
> +            }

Why is this needed here?  I would think you would only need this in determinedStart... below.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.