[Webkit-unassigned] [Bug 62718] [GTK] Consider rows being ignored when adding children to tables

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62718


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98358|review?                     |review+
               Flag|                            |




--- Comment #3 from chris fleizach <cfleizach at apple.com>  2011-06-23 09:39:15 PST ---
(From update of attachment 98358)
View in context: https://bugs.webkit.org/attachment.cgi?id=98358&action=review

r=me with suggested fixes

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:309
> +

looks like you could put this after the !coreParent check, then you wouldn't need to check coreParent in this if statement

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:319
> +    unsigned tableChildrenCount = tableChildren.size();

i think this unsigned should be a size_t, along with cellsCount (size vector.size() returns size_t i believe)

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:323
> +    for (unsigned i = 0; i < tableChildrenCount; ++i) {

size_t for the i as well

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:352
> +

size_t change

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:358
> +            if (static_cast<unsigned>(index) < cellsCount + rowChildrenCount)

you could probably static_cast<index> one time before the loop, so it doesn't have to be done everytime within the loop

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:403
> +    AccessibilityObject* grandParent = parent->parentObjectUnignored();

you should probably verify parent != 0 before getting gradparent

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:410
> +

size_t

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:418
> +

size_t

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.