[Webkit-unassigned] [Bug 63249] [UNIX] Fix compile warnings in NetscapePluginX11.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63249


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98337|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-06-23 08:10:41 PST ---
(From update of attachment 98337)
View in context: https://bugs.webkit.org/attachment.cgi?id=98337&action=review

Looks good, but I have a few minor requests before landing.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:362
> +    case WebMouseEvent::LeftButton:
> +    default:
> +        xButton.button = Button1;
> +        break;

If we are receiving other types of events shouldn't we be passing them properly to the plugin. I think it's more correct to simply have ASSERT_NOT_REACHED() for default:. This makes me wonder whether wheel events are supported or not.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:414
> +    default:
> +        return false;

I would rather you list them explicitly here. Do you mind changing that before landing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.