[Webkit-unassigned] [Bug 63248] [GTK] Install a custom X error handler in plugin process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63248





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-06-23 08:07:30 PST ---
(In reply to comment #2)
> (From update of attachment 98336 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98336&action=review
> 
> > Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.cpp:41
> > +    gchar errorMessage[64];
> > +    XGetErrorText(xdisplay, error->error_code, errorMessage, 63);
> 
> Is 64 enough here?

it's based on GDK code, see:

http://git.gnome.org/browse/gtk+/tree/gdk/x11/gdkdisplay-x11.c#n2351

so I guess it's enough, we could use something like 1024 to make sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.