[Webkit-unassigned] [Bug 63086] [EFL] DRT: Add DumpRenderTreeView, an ewk_view specialization for DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63086





--- Comment #2 from Kent Tamura <tkent at chromium.org>  2011-06-23 02:27:47 PST ---
(From update of attachment 98038)
View in context: https://bugs.webkit.org/attachment.cgi?id=98038&action=review

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:38
> +static void onConsoleMessage(Ewk_View_Smart_Data* sd, const char* message, unsigned int lineNumber, const char* sourceID)

'sd' isn't a good name.
Also, we don't need to write argument names if they aren't used in the function body.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:43
> +static void onJavaScriptAlert(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message)

ditto.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:48
> +static Eina_Bool onJavaScriptConfirm(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message)

ditto.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:54
> +static Eina_Bool onJavaScriptPrompt(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message, const char* defaultValue, char** value)

ditto.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:61
> +Evas_Object* drtViewTiledAdd(Evas* e)

'e' is not a good name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.