[Webkit-unassigned] [Bug 63234] New: line ending strip suggestion in KeywordLookupGenerator.py

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63234

           Summary: line ending strip suggestion in
                    KeywordLookupGenerator.py
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows XP
            Status: UNCONFIRMED
          Severity: Enhancement
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: hgneng at gmail.com


Hi, I am trying to build Webkit in Cygwin. The source is checkout with TortoiseSVN. When I run build-webkit, KeywordLookupGenerator.py throws error of "expected description ending with @end". I think it's a line ending issue. I suggest making a small improvement in this script:

In about line 68:
    if not terminator == "@end"

Change it to:
    if not terminator.rstrip() == "@end"

It works for me currently although I am trying to fix another compiling issues...

Thanks a lot!

Cameron Wong

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.