[Webkit-unassigned] [Bug 61931] WebKitTestRunner needs an implementation of setTextDirection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61931


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98127|0                           |1
        is obsolete|                            |
  Attachment #98127|review?                     |
               Flag|                            |
  Attachment #98321|                            |review?
               Flag|                            |




--- Comment #6 from Hironori Bono <hbono at chromium.org>  2011-06-23 01:02:52 PST ---
Created an attachment (id=98321)
 --> (https://bugs.webkit.org/attachment.cgi?id=98321&action=review)
Patch v3 (fixed a memory leak)

Greetings Jessie,

Thank you for your review and comment.

(In reply to comment #5)
> (From update of attachment 98127 [details])
> > Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp:1577
> > +    framePrivate->setTextDirection(directionBSTR);
> 
> Potential leak: where is directionBSTR freed?

Thank you for noticing this leak. I totally forgot calling SysFreeString(). I have added a SysFreeString() call after this line.

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.