[Webkit-unassigned] [Bug 61272] [Chromium] On-the-spot IME support for windowless plug-ins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61272





--- Comment #17 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-06-22 10:50:37 PST ---
(In reply to comment #12)
> > i'm concerned about defining plugin-specific input events.  can you tell me more about
> > why these are input events for plugins and not input events for WebWidgets?  why wouldn't
> > we just add methods for setting and confirming composition on WebPlugin?
> 
> Thank you for your comment. I have also considered this option before I started implementing this change. In brief, I have added an input event just because an IME event was mostly coupled with a keyboard events and it looked safer to use the same framework that sends keyboard events to send IME events. I'm not sure which is the better option in terms of sharing code between Chromium and Safari, adding an input event or adding a method to WebPlugin. Unfortunately, my Safari change for this issue is still in progress. (Even though this change is currently a Chromium-specific change, I would like to share code with Safari Win as much as possible.)


Note, also that WebInputEvent is intended to match up with WebCore::Platform*Event.  You are adding a case where that is not true.

Also, I see that you are not eliminating WebWidget::*composition methods in favor of using input events for IME.  It just seems to me that we would be better served with an API on WebPlugin for IME composition that mirrors the API we have on WebWidget.

Perhaps we could even distill that API into a separate interface, which both WebWidget and WebPlugin extend?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.