[Webkit-unassigned] [Bug 63060] [GTK] Use GOption to parse main arguments in GtkLauncher

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 22 08:32:20 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63060





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-06-22 08:32:20 PST ---
(In reply to comment #5)
> (From update of attachment 98144 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98144&action=review
> 
> Great stuff. it doesn't seem like settings will "stick" for other WebViews opened unfortunatelyi. I guess we can fix that in a followup patch since it's sort of unrelated to this.

https://bugs.webkit.org/show_bug.cgi?id=63142

> > Tools/GtkLauncher/main.c:379
> > +    static WebKitWebSettings *webkitSettings = 0;
> > +#endif
> > +    static const gchar **uriArguments = 0;
> > +    static const GOptionEntry commandLineOptions[] =
> 
> If I'm not mistaken these do not have to be static. Please check before landing.

Right, not necessarily, removed already. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list