[Webkit-unassigned] [Bug 63060] [GTK] Use GOption to parse main arguments in GtkLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63060


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98144|review?                     |review+
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-06-22 07:49:36 PST ---
(From update of attachment 98144)
View in context: https://bugs.webkit.org/attachment.cgi?id=98144&action=review

Great stuff. it doesn't seem like settings will "stick" for other WebViews opened unfortunatelyi. I guess we can fix that in a followup patch since it's sort of unrelated to this.

> Tools/GtkLauncher/main.c:379
> +    static WebKitWebSettings *webkitSettings = 0;
> +#endif
> +    static const gchar **uriArguments = 0;
> +    static const GOptionEntry commandLineOptions[] =

If I'm not mistaken these do not have to be static. Please check before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.