[Webkit-unassigned] [Bug 60303] animation-timing-function property with a list uses first item for all animations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 22 07:30:36 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60303





--- Comment #7 from Young Han Lee <joybro at company100.net>  2011-06-22 07:30:36 PST ---
(In reply to comment #5)
> (From update of attachment 98005 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98005&action=review
> 
> > LayoutTests/animations/multiple-animations-on-an-element.html:35
> > +        runAnimationTest(expectedValues, null, null, true);
> 
> Why does this have to disable the pause API?

Because the test failed when the pause API is enabled, but I just found out that runAnimationTest always fails if the pause API is enabled and the test target animation has "infinite" iteration count.

Is this a bug, too?

Anyway, I changed the iteration count and enabled the pause API in the new patch.

> 
> > Source/WebCore/page/animation/KeyframeAnimation.cpp:153
> > +    const Animation* matchedAnimation = getAnimationFromStyleByName(fromStyle, name());
> > +    if (matchedAnimation)
> 
> We usually write this:
> if (const Animation* matchedAnimation = getAnimationFrom...)
>     ...

This is also changed.

Thanks :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list