[Webkit-unassigned] [Bug 62808] [Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62808





--- Comment #6 from Benjamin Poulain <benjamin at webkit.org>  2011-06-22 07:07:10 PST ---
Quick comments. No idea if the patch is the right solution (maybe Luiz can help here) but I don't like the patch in general because:
-deferring the change of a setter is a bad idea, that leads to hard to read code. You should have imperative way of setting deferred with queueing.
-You don't need a QTimer here since the current object is a QObject. A single shot timer on self would be cleaner (QBasicTimer for example)
-It looks like you just want to have a signal in the end of the event queue. You probably don't even need a timer here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.