[Webkit-unassigned] [Bug 61140] [GTK] Add HTML5 Notifications support

Wed Jun 22 00:00:26 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=61140

--- Comment #21 from Alexandre Mazari <scaroo at gmail.com>  2011-06-22 00:00:26 PST ---
(In reply to comment #18)
> OK, after reading a bit about this, this is what I think would be a reasonable design for it:
> 
> - The permission bits would go in the WebView, as signals, to keep things consistent with what we have.
> 
> - There's one extra signal when the WebView wants to show a particular notification. The UA can connect to this and do whatever it wants with it.
> 
I am really not sure signals are the best tools here: there  will always be only one interested party that will share state across calls. Class are made for that purpose by giving type safety and separation of concerns.
WebKitWebView and the mirroring EphyWebView are alreadyd kinda bloated IMHO with signals/handlers with unrelated concerns and the respective state. 

> - We have a notification object with all the data bits and two signals, show and cancel. This is the DOM object defined in the spec and available in our GObject bindings if we enable it (I don't think we are doing this now).
> 

Yeah reusing thate would be great, but the generated WebKitDOMNotification do not have fields/properties for the actual notification content (title, body and icon url). Somehow the IDL (Source/WebCore/notifications/Notification.idl) do not declare them.

> Also all the mentions to JavaScript in the doc are wrong, this is not directly related to JS other than JS being the default language to access the DOM from browsers.

You are right.

> This is mostly from reading http://www.w3.org/TR/notifications/#bib-PERMISSIONS and the suggested patch.

Thanks for the throughout review !

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.