[Webkit-unassigned] [Bug 62961] [EFL] Add GraphicsContext3DInternal implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62961





--- Comment #17 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-06-21 22:40:10 PST ---
(From update of attachment 98115)
View in context: https://bugs.webkit.org/attachment.cgi?id=98115&action=review

When you define functions, you need to adhere consistency in parameter name. AFAIK, we have to adhere WebKit coding style rule in WebCore,

> Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.h:57
> +    void blendFuncSeparate(GC3Denum srcRGB, GC3Denum dstRGB, GC3Denum srcAlpha, GC3Denum dstAlpha);

you use "A" upper case in srcAlpha.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.h:70
> +    void copyTexImage2D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dint x, GC3Dint y, GC3Dsizei width, GC3Dsizei height, GC3Dint border);

In internalformat, you don't use upper case for "f".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.