[Webkit-unassigned] [Bug 63062] Add capture attribute for HTML Media Capture

Tue Jun 21 21:32:44 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=63062

--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-06-21 21:32:44 PST ---
(From update of attachment 97971)
View in context: https://bugs.webkit.org/attachment.cgi?id=97971&action=review

I'm wondering if media capture feature can work on this patch.

> Source/WebCore/ChangeLog:16
> +        No new tests.

If you don't have test cases, remove above line or add the reason why your patch doesn't have test case.

> Source/WebCore/html/HTMLInputElement.cpp:1235
> +#if ENABLE(MEDIA_CAPTURE)

IMO, you have to define disabled ENABLE_MEDIA_CAPTURE. And also, this feature can be adjusted to all ports. Thus, you SHOULD add the macro to configuration files of all ports.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.