[Webkit-unassigned] [Bug 43446] [EFL] Exporting JavaScript objects for EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43446





--- Comment #23 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-06-21 20:04:53 PST ---
(From update of attachment 97605)
View in context: https://bugs.webkit.org/attachment.cgi?id=97605&action=review

> Source/WebKit/efl/ewk/ewk_js.cpp:21
> +

You don't need to add empty line to here.

> Source/WebKit/efl/ewk/ewk_js.cpp:93
> +       return (Ewk_JS_Object*)np_obj;

Please adhere indentation.

> Source/WebKit/efl/ewk/ewk_js.cpp:96
> +        return 0;

ditto.

> Source/WebKit/efl/ewk/ewk_js.cpp:714
> +#else

Personally, I don't like to make dummy functions for macro. Other ewk functions are using macro its inside for disabling macro.

const char *ewk_settings_web_database_path_get(void)
{
#if ENABLE(DATABASE)
    return _ewk_default_web_database_path;
#else
    return 0;
#endif
}

> Source/WebKit/efl/ewk/ewk_private.h:1
> +

Please remove empty line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.