[Webkit-unassigned] [Bug 63094] New: webkit-patch gets confused if git local and global usernames are different

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63094

           Summary: webkit-patch gets confused if git local and global
                    usernames are different
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org, dbates at webkit.org


webkit-patch gets confused if git local and global usernames are different

% git config --global bugzilla.username
commit-queue at webkit.org

% git config bugzilla.username
webkit.review.bot at gmail.com

When I run webkit-patch patches-to-review (or any other command which uses authentication).  This is what I see:

Logging in as commit-queue at webkit.org
webkit.review.bot at gmail.com...
Bugzilla login failed: Invalid Username or Password.

I think that the problem is the --get-all:

    @classmethod
    def read_git_config(cls, key, cwd=None):
        # FIXME: This should probably use cwd=self.checkout_root.
        # Pass --get-all for cases where the config has multiple values
        # Pass the cwd if provided so that we can handle the case of running webkit-patch outside of the working directory.
        return run_command(["git", "config", "--get-all", key], error_handler=Executive.ignore_error, cwd=cwd).rstrip('\n')

I suspect we're not expecting to actually get more than one value back from git config.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.