[Webkit-unassigned] [Bug 63007] Web Inspector: Show "no content" message in network panel when resource does not have content available.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 02:28:35 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63007





--- Comment #2 from Yury Semikhatsky <yurys at chromium.org>  2011-06-21 02:28:35 PST ---
(From update of attachment 97850)
View in context: https://bugs.webkit.org/attachment.cgi?id=97850&action=review

The change looks good except the code duplication in _ensureInnerViewShown

> Source/WebCore/inspector/front-end/ResourceResponseView.js:34
> +    

Remove extra line.

> Source/WebCore/inspector/front-end/ResourceResponseView.js:56
> +    _ensureInnerViewShown: function()

This method is very similar to ResourcePreviewView.prototype._ensureInnerViewShown above could you factor out common code into a new method/class and use it from both places?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list