[Webkit-unassigned] [Bug 63044] [EFL] Makes themeForPage() return static RenderThemeEfl.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63044





--- Comment #5 from Jaehun Lim <ljaehun.lim at samsung.com>  2011-06-21 01:55:58 PST ---
(In reply to comment #2)
> (In reply to comment #0)
> > 364    PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page* page)
> > 365    {
> > 366        if (page)
> > 367            return RenderThemeEfl::create(page);
> > 368    
> > 369        static RenderTheme* fallback = RenderThemeEfl::create(0).releaseRef();
> > 370        return fallback;
> > 371    }
> > 
> > First,
> > If Page exsists, RenderThemeEfl is created whenever themeForPage() is called.
> > But themeForPage() doesn't have to create RenderThemeEfl for every time.
> > 
> I can't understand it.
> If user use different theme for each views, Is it OK?

In my patch, themeForPage() does not support mutilple-theme like other ports.
AFAIK, other WebKit ports do not consider multiple-theme.
If EFL requeires it, I'll try to make a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.