[Webkit-unassigned] [Bug 63044] New: [EFL] Makes themeForPage() return static RenderThemeEfl.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63044

           Summary: [EFL] Makes themeForPage() return static
                    RenderThemeEfl.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit EFL
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ljaehun.lim at samsung.com
                CC: demarchi at webkit.org, gyuyoung.kim at webkit.org


364    PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page* page)
365    {
366        if (page)
367            return RenderThemeEfl::create(page);
368    
369        static RenderTheme* fallback = RenderThemeEfl::create(0).releaseRef();
370        return fallback;
371    }

First,
If Page exsists, RenderThemeEfl is created whenever themeForPage() is called.
But themeForPage() doesn't have to create RenderThemeEfl for every time.

Second,
The functions in the fallback theme(=Page is NULL) just call the normal theme(=Page is not NULL)'s functions.
(Please see the adjustXXXStyle() functions.)
If EFL port doesn't have the special fallback theme mecahnism, it's better not to make a fallback theme.

* Other ports except QT have the simillar themeForPage() function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.