[Webkit-unassigned] [Bug 62838] [Qt] [WK2] Add drag and drop support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 20 20:32:06 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62838


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #5 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-06-20 20:32:06 PST ---
Attachment 97920 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/WebPageProxy.h:448:  The parameter name "dragData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/API/qt/qwkpage_p.h:75:  The parameter name "dragData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/Shared/qt/ArgumentCodersQt.cpp:38:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/WebPage/WebPage.h:382:  The parameter name "dragData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/Shared/qt/ArgumentCodersQt.h:29:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/Shared/qt/ArgumentCodersQt.h:33:  The parameter name "encoder" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/Shared/qt/ArgumentCodersQt.h:33:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/Shared/qt/ArgumentCodersQt.h:34:  The parameter name "decoder" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/Shared/qt/ArgumentCodersQt.h:34:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/PageClient.h:107:  The parameter name "dragData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 11 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list