[Webkit-unassigned] [Bug 62954] add/removeSpellcheckRange use RefPtr incorrectly for arguments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62954


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97783|0                           |1
        is obsolete|                            |
  Attachment #97783|review?, commit-queue?      |
               Flag|                            |
  Attachment #97900|                            |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Hironori Bono <hbono at chromium.org>  2011-06-20 18:09:42 PST ---
Created an attachment (id=97900)
 --> (https://bugs.webkit.org/attachment.cgi?id=97900&action=review)
A quick patch v1

Greetings Darin,

(In reply to comment #2)
> (From update of attachment 97783 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97783&action=review
> 
> > Source/WebCore/dom/DocumentMarkerController.cpp:686
> > +bool DocumentMarkerController::addUserSpellingMarker(Node* node, unsigned start, unsigned length, PassRefPtr<DOMStringList> srcSuggestions, unsigned options)
> 
> The prefix we use here is “prp”, not “src”.

Thank you for noticing it. (I'm a little wondering why check-webkit-style did not notice it, though. It may be a good idea to write a change for it?) I have updated this change to use prp prefixes for PassRefPtr arguments. Is it possible to review the updated one?

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.