[Webkit-unassigned] [Bug 62977] Web Inspector: [V8] Tab crashes in chromium after opening inspector on about:blank.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62977





--- Comment #16 from Dmitry Lomov <dslomov at google.com>  2011-06-20 16:29:30 PST ---
(In reply to comment #11)
> (In reply to comment #9)
> > (In reply to comment #7)
> > > (In reply to comment #6)
> > > > (From update of attachment 97849 [details] [details] [details] [details])
> > > > Sounds like Vitaly is saying r-. This seems fragile indeed: there is nothing preventing us from introducing another 'poor' call site. Other subsystems (such as content scripts on static pages) also seem vulnerable unless covered implicitly.
> > > 
> > > Yeah, I somehow thought that lazy initialization will be costly but my recent investigations suggest otherwise. I'll validate that and go with it if successful.
> > > 
> > > I do not think there is a good way to initialize V8 globally though.
> > 
> > Lazy init is a noticable hit on Linux:
> > http://dromaeo.com/?id=142531,142743
> > So I'll try global initialization.
> 
> Can you share the patch please?

The patch is pretty much this:
       static V8BindingPerIsolateData* get(v8::Isolate* isolate)
        {
            void* data = isolate->GetData();
            if (UNLIKELY(data == 0))
              return create(isolate);
            return static_cast<V8BindingPerIsolateData*>(data); 
        }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.