[Webkit-unassigned] [Bug 62780] Migrate SQLite backing store to LevelDB backing store for Indexeddb.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62780





--- Comment #6 from Greg Simon <gregsimon at chromium.org>  2011-06-20 15:42:41 PST ---
(In reply to comment #4)
> (From update of attachment 97405 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97405&action=review
> 
> > Source/WebCore/storage/IDBFactoryBackendImpl.cpp:127
> >  bool IDBFactoryBackendImpl::migrate(const String& name, SecurityOrigin* securityOrigin, const String& dataDir, int64_t maximumSize)
> 
> Seems like we could have broken this gigantic function into smaller (static/inline) helpers to help readability.

Correct -- I broke up the migration code itself into a static function.

> 
> > Source/WebCore/storage/IDBFactoryBackendImpl.cpp:183
> > +        if (!toObjStoreNames.contains(fromObjStoreNames[i])) {
> 
> Early continue?
It is correct as written -- we are limiting our "merge" migration objectstores as a whole. If the object store exists at the target we move onto the next one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.