[Webkit-unassigned] [Bug 62848] Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62848


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97740|review?                     |review-
               Flag|                            |




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-06-20 11:06:40 PST ---
(From update of attachment 97740)
View in context: https://bugs.webkit.org/attachment.cgi?id=97740&action=review

> Source/WebCore/platform/WidgetBackingStore.h:7
> +/*
> + * Copyright (C) 2011, Igalia S.L.
> + *
> + *  This library is free software; you can redistribute it and/or
> + *  modify it under the terms of the GNU Lesser General Public
> + *  License as published by the Free Software Foundation; either
> + *  version 2 of the License, or (at your option) any later version.

This file probably belongs in the Cairo subdirectory since it heavily depends on Cairo.

> Source/WebCore/platform/gtk/GtkWidgetBackingStoreCairo.cpp:34
> -static PassRefPtr<cairo_surface_t> createSurfaceForBackingStore(GtkWidget* widget, const IntSize& size)
> +static PassRefPtr<cairo_surface_t> createSurfaceForBackingStore(PlatformWidget widget, const IntSize& size)
>  {
>      return gdk_window_create_similar_surface(gtk_widget_get_window(widget),
>                                               CAIRO_CONTENT_COLOR_ALPHA,

I'm not sure I understand this part of the change. Here we abstract away that the widget is a GTK+ widget and then immediately call gtk_widget_get_window on it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.