[Webkit-unassigned] [Bug 55308] [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 20 09:22:58 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=55308


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97700|review?                     |review+
               Flag|                            |




--- Comment #19 from Martin Robinson <mrobinson at webkit.org>  2011-06-20 09:22:58 PST ---
(From update of attachment 97700)
View in context: https://bugs.webkit.org/attachment.cgi?id=97700&action=review

Nice work! I'll land this one.

> Tools/GtkLauncher/main.c:280
> +        return NULL;

You should use 0 here instead of NULL.

> Tools/GtkLauncher/main.c:285
> +        return NULL;

Ditto.

> Tools/GtkLauncher/main.c:359
> +    GError *error = NULL;

You should use 0 instead of NULL unless you are ending an argument list. I'll fix this and land.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list