[Webkit-unassigned] [Bug 62954] add/removeSpellcheckRange use RefPtr incorrectly for arguments

Mon Jun 20 05:19:53 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=62954

Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97783|                            |review?, commit-queue?
               Flag|                            |

--- Comment #1 from Hironori Bono <hbono at chromium.org>  2011-06-20 05:19:53 PST ---
Created an attachment (id=97783)
 --> (https://bugs.webkit.org/attachment.cgi?id=97783&action=review)
A quick patch v0

Greetings,

(In reply to comment #0)
> Arguments should be PassRefPtr or raw pointers, never RefPtr.

Thank you for noticing it. I have replaced all the RefPtr arguments in my r88332: <http://trac.webkit.org/changeset/88332> with PassRefPtr. (Even though I have not tried this change on valgrind, I think this change works without memory leaks.) It would be definitely helpful to give me feedback.

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.