[Webkit-unassigned] [Bug 61890] make-hash-tools.pl: Perl 5.14 compatibility

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61890





--- Comment #1 from Andras Becsi <abecsi at webkit.org>  2011-06-20 05:11:15 PST ---
(In reply to comment #0)
> Created an attachment (id=95682)
 --> (https://bugs.webkit.org/attachment.cgi?id=95682&action=review) [details]
> Patch for make-hash-tools.pl to use given/when instead of switch
> 
> The make-hash-tools.pl script, executed during the build process, uses the Switch module which has been removed from Perl 5.14.
> 
> In Arch Linux, we decided to patch make-hash-tools.pl to use the new given/when keywords available in Perl >= 5.10. I have attached our patch, which is quite trivial. However, you might want to retain compatibility with oder Perl versions, in which case a different patch will be needed (my Perl-fu is weak, and can't make a conditional dependency on either the Switch module or the new given/when syntax).
> 
> Other reports of this issue:
> 
> Gentoo: http://bugs.gentoo.org/show_bug.cgi?id=364489
> FreeBSD: http://www.mail-archive.com/freebsd-ports@freebsd.org/msg33878.html

Because this is a generator script where performance is not an issue since, I think these could be simply changed to if/elif constructions, so we wouldn't need to worry about compatibility.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.