[Webkit-unassigned] [Bug 62863] [Qt] Orientation sensor is always on, which has negative impact on battery life.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62863


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97638|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #5 from Andreas Kling <kling at webkit.org>  2011-06-20 02:51:30 PST ---
(From update of attachment 97638)
View in context: https://bugs.webkit.org/attachment.cgi?id=97638&action=review

> Source/WebKit/qt/Api/qwebframe.h:203
> +    void stopOrientationSensor() const;
> +    void startOrientationSensor() const;

'const' does not make semantic sense for these methods, as they alter the state of the object.
Also, for internal methods, we typically do something like:

void QWEBKIT_EXPORT qtwebkit_webframe_setOrientationSensorEnabled(QWebFrame* frame, bool enabled)

(This goes in the cpp file to avoid polluting public headers with internal API.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.