[Webkit-unassigned] [Bug 62965] New: webkit-patch/svn-create-patch created patch with invalid chunk range lines

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 19 22:37:43 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62965

           Summary: webkit-patch/svn-create-patch created patch with
                    invalid chunk range lines
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dbates at webkit.org
                CC: eric at webkit.org, oliver at apple.com, jmont at apple.com


The attachment 97685 (of bug #62613) failed to apply because it's malformed since it contains invalid chunk range lines.

For example, the diff for JSCParser.cpp contains the following chunk:

[[
@@ -71,8 +82,9 @@ COMPILE_ASSERT(LastUntaggedToken < 64, L

 class JSParser {
 public:
-    JSParser(Lexer*, JSGlobalData*, FunctionParameters*, bool isStrictContext, bool isFunction, SourceProvider*);
-    const char* parseProgram();
+    JSParser(Lexer*, JSGlobalData*, FunctionParameters*, bool isStrictContext, bool isFunction, const SourceCode*);
+    UString parseProgram();
 private:
     struct AllowInOverride {
         AllowInOverride(JSParser* parser)
]]

But the chunk range line should be @@ -71,8 +82,8 @@ (since we have 8 lines of text after the change - the same number of lines we started with)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list