[Webkit-unassigned] [Bug 49739] WebIDL attributes should be implemented as getters and setters on the prototype object.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49739





--- Comment #10 from Oliver Hunt <oliver at apple.com>  2011-06-19 17:16:58 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> 
> Thanks for the insight.
> 
> > Correction: I know that setters aren't cached.  Assigning to dom properties would be hammered, but they are theoretically already slow.  If we added caching to setters we would probably end up with a net win.
> > 
> > > Getters will be hit by additional branches to validate the proto chain which is unfortunate.
> > 
> > This will suck, but given that they're getter/setter pairs that we provide we might be able to remove at least _a_ branch from the current cached path.  We should also be able to avoid constructing an actual function wrapper until we absolutely have to (getOwnPropertyDescriptor requires us to provide the function object)
> 
> Could you point me to where this cache is in JSC?

What cache?

> > This is really an issue that needs to be resolves -- do index properties move to the prototype or do 
they stay own properties?
> 
> According to the Web IDL spec, indexed properties are on the host object, not the prototype <http://www.w3.org/TR/WebIDL/#indexed-properties>

Do they end up as getters or values?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.