[Webkit-unassigned] [Bug 62669] [Qt] Add storage tracker WK1 API for QtWebKit port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62669





--- Comment #3 from Yael <yael.aharon at nokia.com>  2011-06-19 15:16:24 PST ---
(From update of attachment 97637)
View in context: https://bugs.webkit.org/attachment.cgi?id=97637&action=review

I am not a reviewer, but have a few comments.

> Source/WebKit/qt/Api/qwebsecurityorigin.cpp:275
> +    Returns a list of all security origins with local storage defined.

I would omit the word "defined" here.

> Source/WebKit/qt/QtWebKit.pro:211
> +        $$PWD/WebCoreSupport/StorageTrackerClientQt.h

This file is missing.

> Source/WebKit/qt/QtWebKit.pro:214
> +        $$PWD/WebCoreSupport/StorageTrackerClientQt.cpp

This file is missing.

> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1178
> +       res.append(((((ret[i].scheme()).append(originDelimeter)).append(ret[i].host())).append(originDelimeter)).append(QVariant(ret[i].port()).toString()));

That hurts my eyes :)
I would use operator + since QStringBuilder is public only from Qt 4.8.

> Tools/DumpRenderTree/qt/DumpRenderTree.pro:10
> +INCLUDEPATH += ../../../Source/WebCore/storage

Don't include WebCore files outside of QtWebKit library.

> Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:52
> +    if (m_localStorageTracker)

This check is not needed.

> Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:81
> +    m_localStorageTracker = 0;

This should also delete storage that might have been created by the test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.