[Webkit-unassigned] [Bug 62943] test-webkitpy --all errors out because scm_unittest.py can't find module checkout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62943





--- Comment #1 from Daniel Bates <dbates at webkit.org>  2011-06-18 16:53:14 PST ---
Created an attachment (id=97709)
 --> (https://bugs.webkit.org/attachment.cgi?id=97709&action=review)
Patch (reference checkout module in parent directory)

I was not sure whether to remove the "from .checkout import Checkout" (since it's imported in <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/__init__.py?rev=85452>) or to change it to read "from ..checkout import Checkout" (so that it references the module which is in our parent directory. I mean, we seem to explicitly import modules even though they appear in a __init__.py. For example, in scm_unittests.py we import from module detection, git, and svn even though these identical imports are in <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/scm/__init__.py?rev=85449> (why?)

What is the best practice for this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.