[Webkit-unassigned] [Bug 61572] KURL::protocolIs(const char* protocol) asserts in Debug builds with valid protocols

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 17 17:28:09 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61572





--- Comment #3 from Darin Adler <darin at apple.com>  2011-06-17 17:28:09 PST ---
The issue is not just an assertion. The code actually works wrong for custom protocols with non-letters.

When I originally wrote this we wanted it to be super-fast for protocols like "http" and "file" and it seemed the right tradeoff to only work with letters. If we want a slightly slower one that can work for any protocol, it's easy to change this into that.

Or we could even have both, although I don't see an obvious way to automatically choose the faster one at compile time.

The current function could be named fastAllLetterProtocolIs or something annoying like that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list