[Webkit-unassigned] [Bug 48297] Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.image.destination-atop.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48297





--- Comment #18 from Julien Chaffraix <jchaffraix at webkit.org>  2011-06-17 16:36:45 PST ---
(From update of attachment 97568)
View in context: https://bugs.webkit.org/attachment.cgi?id=97568&action=review

>>> LayoutTests/platform/gtk/Skipped:-1104
>>> -canvas/philip/tests/2d.composite.uncovered.image.source-out.html
>> 
>> Removing passing test from the Skipped list is great! However we prefer atomic patches. I would bet that source-{in|out} were passing without your change and thus are orthogonal to the current change. Could you split the patch in 2 and move the orthogonal Skipped changes to the other bugs (or correct me if I missed something).
> 
> If you see, we have removed the following test cases
> 
> -BUGWK39177 : canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.html = TEXT
> -BUGWK39177 : canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop.html = TEXT
> [The above test cases are related to our current changes of adding CompositeDestinationAtop in shouldDisplayTransparencyElsewhere()]
> 
> -BUGWK39177 : canvas/philip/tests/2d.composite.uncovered.image.destination-atop.html = TEXT
> -BUGWK39177 : canvas/philip/tests/2d.composite.uncovered.image.destination-in.html = TEXT
> -BUGWK39177 : canvas/philip/tests/2d.composite.uncovered.image.source-in.html = TEXT
> -BUGWK39177 : canvas/philip/tests/2d.composite.uncovered.image.source-out.html = TEXT
> [The above test cases are related to calling shouldDisplayTransparencyElsewhere() & displayTransparencyElsewhere() from drawImage(). So these test cases are also passing because of these changes, they were not passing before.]
> 
> Therefore, I don't see any need of splitting the changes. Let me know if I answered you.
> 
> Will update the patch with proper review comment.

I think you just showed that there is actually 2 orthogonal changes in one here by splitting the test cases in 2 different groups.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.