[Webkit-unassigned] [Bug 58498] WebGL should create a single-sample context if creating multisampled context fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58498





--- Comment #4 from Zhenyao Mo <zmo at google.com>  2011-06-17 12:33:59 PST ---
We don't exactly know on which hardware the multisampled FBO creation might fail.  You'll have to emulate failure in the multisampled path to test the recovering and fallback to non-multisampled path.

(In reply to comment #3)
> Thanks, Mo.
> 
> So can we reproduce on any Mac environment?
> Do we need any specific hardware configuration, such as GPU type?
> 
> (In reply to comment #2)
> > One place you can look at is webcore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp, reshape function.
> > 
> > In that function, if m_attrs.antialias is true, then we try to create a multisampled FBO for rendering.
> > 
> > Currently that code path doesn't recover from error.  So what we need to do is
> > 
> > 1) check if creation of multisampled FBO succeeds or not.
> > 2) if it failed, set m_attrs.antialias = false, and try again.
> > 
> > One thing unclear to me is that it seems attributes.antialias might change in the lifetime of a context.  I am not sure if it's OK or not.
> > 
> > Hope this helps.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.