[Webkit-unassigned] [Bug 48297] Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.image.destination-atop.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48297





--- Comment #16 from Julien Chaffraix <jchaffraix at webkit.org>  2011-06-17 09:59:24 PST ---
(From update of attachment 97568)
View in context: https://bugs.webkit.org/attachment.cgi?id=97568&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1517
> +    // to display transparency elsewhere, therefore adding the check for CompositeDestinationAtop

I would rather see a 'why' comment than a 'what' comment. Everybody can check against HTML5 that we are doing the right stuff here. However knowing *why* we need to add CompositeDestinationAtop but not CompositeSourceAtop is much more valuable to people reading the code and wondering why we have such a discrepancy.

> LayoutTests/platform/gtk/Skipped:-1104
> -canvas/philip/tests/2d.composite.uncovered.image.source-out.html

Removing passing test from the Skipped list is great! However we prefer atomic patches. I would bet that source-{in|out} were passing without your change and thus are orthogonal to the current change. Could you split the patch in 2 and move the orthogonal Skipped changes to the other bugs (or correct me if I missed something).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.