[Webkit-unassigned] [Bug 62863] In QWebFrame, m_orientation is started but never stopped

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62863


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97603|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Andreas Kling <kling at webkit.org>  2011-06-17 09:06:27 PST ---
(From update of attachment 97603)
View in context: https://bugs.webkit.org/attachment.cgi?id=97603&action=review

What about QGraphicsWebView?
And this feels very hackish, I don't think all users of Q*WebView would want the orientation events to disappear when the app is in the background.
Perhaps we could have an explicit API (on QWebFrame) to enable/disable the accelerometer? I'd probably \internal that kind of API though.

> Source/WebKit/qt/Api/qwebview.cpp:830
> +        QWebFrame* frame = page()->mainFrame();

You should use d->page instead of page() here.

> Source/WebKit/qt/Api/qwebview.cpp:834
> +        if (e->type() == QEvent::WindowDeactivate)
> +              frame->d->m_orientation.stop();
> +        if (e->type() == QEvent::WindowActivate)
> +              frame->d->m_orientation.start();

Coding style, tabs are 4 spaces. Also, second condition should be 'else if'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.