[Webkit-unassigned] [Bug 61140] [GTK] Add HTML5 Notifications support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61140





--- Comment #9 from Alexandre Mazari <scaroo at gmail.com>  2011-06-17 07:56:32 PST ---
(In reply to comment #7)
> Created an attachment (id=97599)
 --> (https://bugs.webkit.org/attachment.cgi?id=97599&action=review) [details]
> Patch

News in this patch:
- Hopefully fix any style issue reported by martin
- Use a C++ object as private struct for WebKitWebNotification
- Match specifications regarding event propagation (do it at actual display time). Useful in the case of notifications queuing by the client.
- Send WebKitSecurityOrigin instances instead of strings for permission requests.
- Public API (signals and methods) documentation
- minimize existing common code modification by reusing those facilities
- Pass all tests but one

Wanted reviews:
- API design
- code style
- memory management (references etc...)

Open questions:
- should cancelling permission request for a specific security origin only remove pending requests or also accepted (by the user) one ?

- should we make html notification handling transparent to the API user ?
(Misnamed) HTML notifications require their content (title, body, icon) be fetched from a provided url. Should that be the client responsibility ?

- again, do we want to add even more signals to WebKitWebView instead of using proper delegation ?


Thanks for your time !

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.