[Webkit-unassigned] [Bug 51941] refactor HTMLLinkElement to allow Link header implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51941





--- Comment #52 from Gavin Peters <gavinp at chromium.org>  2011-06-17 07:01:06 PST ---
(In reply to comment #51)
> (From update of attachment 97348 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97348&action=review
> 
> > Source/WebCore/html/LinkRelAttribute.cpp:48
> > +            {
> > +            }
> 
> Bad indent.

Fixed.


> > Source/WebCore/html/LinkRelAttribute.cpp:52
> > +    *this = tokenize(rel);
> 
> Crazy!  I would just make this a private member function rather than doing this bizarre thing.  The one caller of this method can just use the constructor and the assignment operator.

I just got rid of the method entirely, now there's just a constructor from a string.

> > Source/WebCore/html/LinkRelAttribute.h:54
> > +    static LinkRelAttribute tokenize(const AtomicString&);
> 
> This probably doesn't need to be an AtomicString.  You're using equalIgnoringCase, so the atomicity isn't really helping.

Now moot, since there's no method and no AtomicString.  So fixed.

> 
> > Source/WebCore/loader/LinkLoader.h:45
> > +/* The LinkLoader can load link rel types icon, dns-prefetch, subresource, prefetch and prerender
> > + */
> 
> C++ style comments pls.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.