[Webkit-unassigned] [Bug 62810] Web Inspector: Network panel does not show main resource content for iframes deleted from the document

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 17 05:56:39 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62810





--- Comment #9 from Pavel Feldman <pfeldman at chromium.org>  2011-06-17 05:56:38 PST ---
(From update of attachment 97586)
View in context: https://bugs.webkit.org/attachment.cgi?id=97586&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:160
> +bool InspectorPageAgent::sharedBufferContent(PassRefPtr<SharedBuffer> buffer, const String& textEncodingName, bool withBase64Encode, String* result)

Consider renaming to non-getter name (fetchSharedBufferConnect).

> Source/WebCore/inspector/NetworkResourcesData.h:72
> +        InspectorPageAgent::ResourceType type() const { return m_type; }

I'd try not to increase the amount of network->page dependencies. Can we keep them separate?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list