[Webkit-unassigned] [Bug 62777] [EFL][WK2] Add RunLoopEfl and WorkQueueEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62777





--- Comment #13 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-06-17 05:00:06 PST ---
It looks much better to me. Thanks for the clarifications WRT the static methods, I needed to brush up that part of my C++ fu :)

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:82
> +    int ret;

I don't think you actually need this variable, you could call select directly in the if clause below.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:130
> +int WorkQueue::getNextTimerID()

Vector::size() returns a size_t, you should keep the same return type.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:150
> +    int timerId = getNextTimerID();

Remember to change timerId's type when you change getNextTimerID().

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:160
> +        item->queue()->scheduleWorkAndWakeUp(item);

Isn't item leaking if item->pid() != ev->pid?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.