[Webkit-unassigned] [Bug 62810] Web Inspector: Network panel does not show main resource content for iframes deleted from the document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62810





--- Comment #3 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2011-06-17 02:32:04 PST ---
(From update of attachment 97484)
View in context: https://bugs.webkit.org/attachment.cgi?id=97484&action=review

The resource buffer extraction changes look sane in general.

> Source/WebCore/inspector/InspectorPageAgent.cpp:156
> +    return InspectorPageAgent::sharedBufferContent(buffer, textEncodingName, withBase64Encode, result);

optional: You might go without the class qualification here and below. Do we have a determined rule for this in the guidelines?

> Source/WebCore/inspector/InspectorPageAgent.cpp:159
> +bool InspectorPageAgent::sharedBufferContent(PassRefPtr<SharedBuffer> buffer, const String& textEncodingName, bool withBase64Encode, String* result)

For static members, we add the "// static" comment on the preceding line

> Source/WebCore/inspector/InspectorPageAgent.cpp:174
> +void InspectorPageAgent::resourceContent(ErrorString* errorString, Frame* frame, const KURL& url, bool base64Encode, String* result)

Please add // static above - I must have missed it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.