[Webkit-unassigned] [Bug 62780] Migrate SQLite backing store to LevelDB backing store for Indexeddb.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62780





--- Comment #4 from Eric Seidel <eric at webkit.org>  2011-06-16 21:04:33 PST ---
(From update of attachment 97405)
View in context: https://bugs.webkit.org/attachment.cgi?id=97405&action=review

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:127
>  bool IDBFactoryBackendImpl::migrate(const String& name, SecurityOrigin* securityOrigin, const String& dataDir, int64_t maximumSize)

Seems like we could have broken this gigantic function into smaller (static/inline) helpers to help readability.

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:183
> +        if (!toObjStoreNames.contains(fromObjStoreNames[i])) {

Early continue?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.