[Webkit-unassigned] [Bug 61915] [EFL][WK2] Add efl port's ewk_view files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 16 17:45:59 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=61915
--- Comment #39 from EunMi Lee <eunmi15.lee at samsung.com> 2011-06-16 17:45:58 PST ---
(In reply to comment #37)
> (From update of attachment 97399 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97399&action=review
>
> LGTM, just some small nits.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:354
> > + if (sd->changed.size) {
> > + if (priv->pageClient)
> > + priv->pageClient->page()->drawingArea()->setSize(IntSize(w, h), IntSize());
> > + sd->view.w = w;
> > + sd->view.h = h;
> > + }
> > + sd->changed.size = EINA_FALSE;
>
> You could move the attribution to sd->changed.size inside the if block. Same below.
Yes, I've moved that inside the if block.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list