[Webkit-unassigned] [Bug 62811] [filesystem/Chromium] Filesystem paths need proper URL escaping

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62811


Eric U. <ericu at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |ericu at chromium.org
                   |kit.org                     |
  Attachment #97512|                            |review?
               Flag|                            |




--- Comment #1 from Eric U. <ericu at chromium.org>  2011-06-16 15:37:48 PST ---
Created an attachment (id=97512)
 --> (https://bugs.webkit.org/attachment.cgi?id=97512&action=review)
Make encodeWithURLEscapeSequences in KURLGoogle.cpp actually do what it says, then use it on filesystem paths.

This fixes KURLGoogle's encodeWithEscapeSequences, which was apparently crippled due to a callsite that no longer exists.  I've removed the obsolete comments, made it actually escape, and used it in the filesystem code.

Tested by running the Blob layout tests.  The blob URL code assumes that this does some escaping, I believe, but so far the lack of it hasn't broken anything [since the strings to be escaped didn't contain anything interesting].  This change doesn't break anything either, as the escaping is harmless in those cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.