[Webkit-unassigned] [Bug 51941] refactor HTMLLinkElement to allow Link header implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51941


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97348|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #51 from Adam Barth <abarth at webkit.org>  2011-06-16 15:11:52 PST ---
(From update of attachment 97348)
View in context: https://bugs.webkit.org/attachment.cgi?id=97348&action=review

> Source/WebCore/html/LinkRelAttribute.cpp:48
> +            {
> +            }

Bad indent.

> Source/WebCore/html/LinkRelAttribute.cpp:52
> +    *this = tokenize(rel);

Crazy!  I would just make this a private member function rather than doing this bizarre thing.  The one caller of this method can just use the constructor and the assignment operator.

> Source/WebCore/html/LinkRelAttribute.h:54
> +    static LinkRelAttribute tokenize(const AtomicString&);

This probably doesn't need to be an AtomicString.  You're using equalIgnoringCase, so the atomicity isn't really helping.

> Source/WebCore/loader/LinkLoader.h:45
> +/* The LinkLoader can load link rel types icon, dns-prefetch, subresource, prefetch and prerender
> + */

C++ style comments pls.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.