[Webkit-unassigned] [Bug 62593] Optimization: do a single fillRect when painting the background in RenderBoxModelObject::paintFillLayerExtended

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62593





--- Comment #15 from Darin Adler <darin at apple.com>  2011-06-16 12:22:07 PST ---
(From update of attachment 97469)
View in context: https://bugs.webkit.org/attachment.cgi?id=97469&action=review

My apologies for not reviewing this before landing it. I still have a bit of concern.

Do we have test cases to cover all the combinations? I’d like to see those. I still worry that base colors with alpha that are neither 0 nor 1 combined with bg colors with alpha other than 0 are not handled correctly. Test cases would make that clear.

Given that the drawImage functions take a composite operator, I’m surprised we don’t have a fillRect that takes a composite operator.

Beyond the correctness issue, I also think we could optimize the case of a base color with alpha of 0 and a bg color with a non-zero alpha so we did not have first the clearRect and then the fillRect.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:751
> +        if (baseColor.alpha() > 0) {

I think we should drop the "> 0" from these to make it closer to our normal coding style

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.